search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

DCO is intrusive anddoes not work with github online edit #109

Closed ssbarnea closed 5 years ago

ssbarnea commented 5 years ago

The fact that DCO requires the added line at each comment makes it very annoying to use and also prevents using the edit functionality in GitHub which auto opens a pull request. Once this pull request was created it will not have the signature on it and it will not be able to fix it.

Instead DCO should only require acceptance the first time when someone contributes, not on each request.

Sidenote, if someone knows a working alternative that does not annoy contributors on each request please let me know. I am looking for bot that would require only one time action on the first commit/PR.

pombredanne commented 5 years ago

You are missing the point of the DCO. This is a per-commit signoff, so DCO (and this bot implementing it) is not what you want.

hiimbex commented 5 years ago

The DCO is based on some legal text (mainly used by corporations working in open source), so I don't think it really fits your needs.

I'm gonna close since there's no action here.

pombredanne commented 5 years ago

@hiimbex

The DCO is based on some legal text (mainly used by corporations working in open source), so I don't think it really fits your needs.

Sorry to nit pick on you!... actually this is not exactly mainly used by corporations working in open source but rather mainly started by Linux and related projects and adopted by other open source projects that like to have a CLA-less, lighter weight way to track and accept contributions like this is done in Linux, the kernel ;)

Ark-kun commented 3 years ago

As some repos are starting to use this bot, contribution is becoming harder, since the DCO bot does not support GitHub.

Could you add support for GitHub please?