dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
297 stars 75 forks source link

Enforce real name #138

Closed fwolter closed 3 years ago

fwolter commented 3 years ago

We have many PRs from users using their GitHub username in the author field.

Is there a way to enforce usage of the real name in the author field? E.g. by checking for a space. This check would have worked for every sign-off with a non-real name I saw until now.

gr2m commented 3 years ago

I'm sorry I'm not sure what you are asking, could you elaborate?

The name is defined in the user's profile. If they don't provide their full name their, there is no way for others to enforce it. Or would you like to enforce it as part of the DCO CI check run? If so, what benefit would that bring?

fwolter commented 3 years ago

We require real names in the sign-off message. So, if the user uses his/her GitHub username in the sign-off message, the automatically run DCO check on PRs turns green, although it's not compliant to our coding guidelines. If I see correctly the author and email address in the sign-off message and in the commit are not set by GitHub, but by the user in his/her Git client. So, it's in the user's hand to use a pseudonym or the real name. I'd like to be able to enforce the real name.

gr2m commented 3 years ago

I see. I'm sorry but out of respect of people's privacy, this is not a feature I'd like to add to DCO because of the harm it could cause. I'd recommend to fork the repository and deploy your own version of DCO with these features, they are out of scope for us

hiimbex commented 3 years ago

+1 https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/