dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Allow single repositories to be excluded via config #172

Open Confectrician opened 2 years ago

Confectrician commented 2 years ago

Hi all,

We are using the dco app enabled for a whole organization, but wanted to exclude the DCO condition "only" for our documentation repository. To do this currently, we would need to remove the global acess on the configuration and then add each needed repository on its own. Also this would force us to maintain this for new repositories each time.

My suggestion would be to add configuration parallel to the members required one, which lets exclude single repositories by placing the dco configuration file in that repository.

I did a quick shot for this in my fork. You can find it here: https://github.com/Confectrician/dco/commit/220b09266b3b775ec3d0bb18f87f725fd26710c3

If you like the idea, i can provide a PR of course.

Best Regards Jerome

gr2m commented 2 years ago

Hi Jerome,

I feel like the best solution would be if GitHub implemented a feature to exclude repositories from a global installation. Could you send a support request at https://support.github.com/contact?

If that won't work, I think I'd prefer this configuration:

require: false

That you would put in the repository's .github/dco.yml file to overwrite the global config

GitHub Support
Confectrician commented 2 years ago

I have added a request via the contact formular. Do you have any impression on how long it takes to get an answer for something like this?

gr2m commented 2 years ago

usually within 1-2 workdays, you should get an answer by end of day Tuesday. By then we should know if GitHub is working on such a feature or not

Confectrician commented 2 years ago

Still no response, but there isn't even a ticket available in my support view. Do you think something went wrong maybe?

gr2m commented 2 years ago

I filed a request with support, you should have gotten it in cc

gr2m commented 2 years ago

just for reference for everyone interested, here is what we heard back from support

Thanks for reaching out and sharing your thoughts! I agree that having an exclusion list would be a neat solution.

Is that something you are working on or consider adding?

There is an open feature request for this with the Apps engineering team and I have added your report as a +1 on the internal issue. I don't have a timeline when it will be worked on but this is currently in good hands.

As it's not already in the works, I don't expect it to happen anytime soon, there was not a lot of activity on GitHub App related features lately

I suggest we leave the issue open to see if others are interested in it as well

Confectrician commented 2 years ago

Fine for me. We have done the "regular" config wy for the openHAB organization meanwhile and included every repo besides the documentation.

Not really satisfying, but it's working. Wa can still add the config value as a workaround, if there is some more interest in this.