search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
296 stars 73 forks source link

Committing a suggested change in github is not signed. #182

Open rijobro opened 2 years ago

rijobro commented 2 years ago

If I create a PR and someone suggests a change which I approve and commit (all via the browser), the commit isn't signed off and then the DCO fails. Since we require all commits to have DCO, this therefore means that we can't use the suggested changes feature in github.

Is there any way around this?

wyli commented 1 year ago

it seems it's now supported by the github web UI to automatically sign https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization

pafdad commented 8 months ago

@wyli thank you for the link. It does however not at all talk about signing suggestions, which I believe is the issue stated by @rijobro. We are having the same issue unfortunately.

wyli commented 8 months ago

Hi @pafdad the doc provides more details https://github.blog/changelog/2022-06-08-admins-can-require-sign-off-on-web-based-commits/