search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
298 stars 75 forks source link

Compare case-insensitively #61

Closed Vampire closed 6 years ago

Vampire commented 6 years ago

I correctly signed off a commit with -s, but the bot complained because my address was not in all lowercase. Please compare case-insensitively.

hiimbex commented 6 years ago

Do you have a link to the commit where this happened? I think this should be an easy fix though, just convert them to lowercase before checking. But that's interesting that the data github gave us about the email address had capitals in it.

Vampire commented 6 years ago

It does not, the signed-off line has the captials: https://github.com/gradle/gradle/pull/4986/commits/204a8f8138b8ea2571f9e94324a1fea5517e32fb

hiimbex commented 6 years ago

Closed via #62 / #65