search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Fix stuff #70

Closed hiimbex closed 6 years ago

hiimbex commented 6 years ago

Fixes #69

I didn't realize requireMembers was actually a function, so I think this should fix it, but honestly I feel like the notation is throwing me off, so I'd appreciate a second set of eyes!

hiimbex commented 6 years ago

👍 yea that's the better thing to do. It's just tough since we don't have any tests for DCO outside of lib/DCO.js.

However I might not get back to this for a bit, since I have finals.