search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Document how to override #73

Closed david-a-wheeler closed 6 years ago

david-a-wheeler commented 6 years ago

Sometimes PRs do not have a DCO, but you want to accept them anyway. There should be a note in the readme explaining how to override this check in specific PRs.

hiimbex commented 6 years ago

When you say "override this check" do you mean allow the PR to be merged while the check is failing? That is usually by default how status checks work on GitHub; however, you can also have required status checks, which would prevent the PR from being merged.

So to override this check, you simply set the DCO as not a required status check and merge when it's failing. Do you think this explanation belongs in the readme?

hiimbex commented 6 years ago

Gonna go ahead and close due to lack of response, but if there's follow up, happy to review a PR to add that content to the readme, but right now I don't feel strongly enough to do it.