search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Read Signed-off-by in pull request text #74

Closed DL6ER closed 5 years ago

DL6ER commented 6 years ago

Dear DCO developers,

we use your bot to enforce Sign-Off lines by our users in our project. However, we often receive external contributions from users with few (or no) previous experience with Github and adding a Signed-Off-by message in all of their commits (by walking the tree and rewriting things) is something that is a bit complex to explain to newcomers.

Hence, our own solution was to ask users to just edit in the requested line into the pull request message and we accept this as being equivalent. However, DCO does not read the pull request text for these lines and hence we have to ignore its false positive for merging.

Can interpreting the pull request text be added in order to ease the process for git newcomers?

hiimbex commented 6 years ago

I'm not opposed to this at all; however, I think some orgs that are stricter in their requiring of DCO might not love this idea, so what about adding this feature as an additional field in the .github/dco.yml as allowPRSignOff: true (and have it be false by default)?

DL6ER commented 6 years ago

Yes, that would be a great idea.

stale[bot] commented 6 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

bkeepers commented 6 years ago

I think this would help a lot with usability.

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

DL6ER commented 5 years ago

Yes, this is still relevant.

Warchant commented 5 years ago

Is anyone working on this?

itayd commented 5 years ago

Hi, I suggest an alternative solution in https://github.com/probot/dco/issues/105. Feel free to share your thoughts.

stale[bot] commented 5 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?