search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Allow multiple SoB lines #75

Closed aparcar closed 5 years ago

aparcar commented 6 years ago

We'd like to use this Bot for OpenWrt but currently it seem to fail if multiple SoB lines are used and the first doesn't match the committer.

I'd suggest to change the current regex and use a while loop checking all found SoB lines.

hiimbex commented 6 years ago

Yea, right now we assume each commit has one SoB line.

Do you want to verify multiple users for the signed off by lines or just check that either the committer or author is included in at least one of the SoB lines?

aparcar commented 6 years ago

The latter would be just perfect.

stale[bot] commented 6 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

tkuhrt commented 5 years ago

We are having this same issue: https://github.com/hyperledger/iroha/pull/1832/checks?check_run_id=28430349. Is any one working on this?

GitHub
Hyperledger Iroha v1.0 beta-5 version by neewy · Pull Request #1832 · hyperledger/iroha
We are happy to introduce various improvements of Hyperledger Iroha for beta-5 release and tell you more about what we accomplished together. There were several major features implemented or prepar...
hiimbex commented 5 years ago

We'd love to have support for this feature!

Is any one working on this?

Not that I know of, but pull requests welcome!

noaos commented 5 years ago

Any reason this is not supported yet? Could be very useful.

ryjones commented 5 years ago

@hiimbex there is an open PR for this: https://github.com/probot/dco/pull/98

tunnckoCore commented 5 years ago

Yup, #98 looks good.