add check for author && author.login to avoid errors when author is null

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests

https://github.com/apps/dco

ISC License

299 stars 75 forks source link

add check for author && author.login to avoid errors when author is null #77

Closed hiimbex closed 6 years ago

hiimbex commented 6 years ago

Closes #69 final issues and Sentry Unresolved type error issues.

So this is happening due to commits not being linked to any user, a state which is common for new GitHub accounts/users to be in.

In this state it appears the author field is null and we check in DCO for the author.login (aka your GitHub login), so I've made the check more thorough to avoid this issue.

byron-marohn commented 6 years ago

If this does indeed fix #69, I'd sure be happy if this got merged. Thanks in advance!

hiimbex commented 6 years ago

Test added!

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: