C H E C K S A P I S U P P O R T 🤩

[hiimbex]

What this PR does:

• Upgrades to Probot 7️⃣. 0️⃣
• Eliminates use of status API ❌
• Uses Checks API aka best API 🎆
• Restructures lib/dco.js to return an array of error messages objects like:

  [{ 
  "author": "Bex Warner",
  "committer": "Bex Warner",
  "message": "The sign-off is missing.",
  "sha": "fe9f33191f3a87c86843292920decab97b5b71b",
  "url": "https://github.com/probot/dco/pull/78/commits/fe9f33191f3a87c86843292920decab97b5b71b"
  }]

• Restructures test/dco.test.js to support that format 🛠
• Adds guidance for ammending your commits 🆘
  • supports git commit --amend --signoff for a mistake in the most recent commit
  • supports git rebase Head~$numOfCommits --signoff for mistakes in multiple commits
  • then instructs git push --force origin $your-branch
• Also includes a list of full length errors for each commit 🔢
• Adds a hard override of the status for anyone with write permissions ✍️

LOOK AT HOW PRETTY IT IS

All commits are signed off:

One commit incorrectly signed off:

Multiple commits incorrectly signed off:

Override button (only visible for those with repo write access):

Todo:

• [x] Properly convert test/index.test.js to v7 and update tests. (tbh I don't fully understand how this test worked before, so not sure how to convert it!)
• [x] Maybe improve code readability/structure because at the moment it's rather hacky

cc/ @probot/maintainers @kytrinyx for 👀& 💭's

[caniszczyk]

omg I’m in love!

[hiimbex]

Tests are now working! @bkeepers I'm blaming you 100% for the DCO failing (also a good motivator to implement https://github.com/probot/dco/issues/75 at some point).

Is there any way we could "staff ship" this big of a change to allow people to opt in to the new behavior?

I'm wondering if you still think this is necessary given that the 'set DCO to passing' otpion is only for those with write access. If you still this is something we should pursue, I'm not sure the best path forward for something like this. Maybe an additional .env variable?

I personally don't think a staff ship is necessary since the only functionality change is giving maintainers a button and using checks not statuses (it should still work in the same way). The other big update that goes with this is updating the permissions the app uses; however, now we get to write a note explaining why! I'm happy to craft one explaining this PR super in depth, so our users know why this change is happening.

But whenever you have ⏳ this is ready for 👀!

[hiimbex]

Just confirmed via https://github.com/hiimbex/testing-things/pull/71 that the existing PRs that swap mid-way from the old statuses to checks don't need any special work or support. The re-written check will overwrite the status.

[hiimbex]

Tests are failing due to https://github.com/facebook/jest/issues/6769 and will I think be fixed in a new Jest release? But it's compeltley unrelated to my changes.

Would love a re-review based on the updates whenever you've got a chance @bkeepers 🙂

[hiimbex]

Consider it 🚢 d!! 🎉

[caniszczyk]

THANK YOU!

On Wed, Aug 22, 2018 at 2:09 PM, Bex Warner notifications@github.com wrote:

Consider it 🚢 d!! 🎉

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/probot/dco/pull/79#issuecomment-415145657, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD5ITSi2pbiUE9DCM8BlkCEvim5CCV8ks5uTaxtgaJpZM4VEr_o .

-- Cheers,

Chris Aniszczyk http://aniszczyk.org +1 512 961 6719

[github-actions[bot]]

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: