search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

DCO check passing when there is not a signoff. #81

Closed JPWKU closed 6 years ago

JPWKU commented 6 years ago

There seems to be an issue here https://github.com/edgexfoundry/edgex-go/pull/376 where the commit is not signed, but the DCO check still passes. Perhaps I'm overlooking something?

hiimbex commented 6 years ago

This was my bad! Definitely a 🐛🐞 Thanks for reporting it

Opened a PR for the fix #82

JPWKU commented 6 years ago

No worries, thanks for responding so quickly!

On Mon, Jul 9, 2018, 12:00 Bex Warner notifications@github.com wrote:

This was my bad! Definitely a 🐛🐞 Thanks for reporting it

Opened a PR for the fix #82 https://github.com/probot/dco/pull/82

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/probot/dco/issues/81#issuecomment-403548278, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj_q4ZtyL_0jQSXkuQGhXARoxj4nKUBks5uE4wqgaJpZM4VICSu .