search

dcoapp / app

GitHub App that enforces the Developer Certificate of Origin (DCO) on Pull Requests
https://github.com/apps/dco
ISC License
299 stars 75 forks source link

Allow multiple SoB lines #98

Closed Warchant closed 5 years ago

Warchant commented 5 years ago

Fixes https://github.com/probot/dco/issues/75

Example

Commit https://github.com/hyperledger/iroha/pull/1832/commits/65631789e50ba4111c4be63bcd21450ad03b3fa3 contains the following message:

Add tests for GetRolePermissions query (#1710)

Signed-off-by: Igor Egorov <igor@soramitsu.co.jp>
Signed-off-by: Vadim Reutskiy <reutskiy@soramitsu.co.jp>

DCO reaction before this PR:

Expected "Vadim Rc sfai.88@gmail.com", but got "Igor Egorov igor@soramitsu.co.jp".

DCO reaction after this PR:

Can not find "Vadim Rc <sfai.88@gmail.com>", in ["Igor Egorov <igor@soramitsu.co.jp>", "Vadim Reutskiy <reutskiy@soramitsu.co.jp>"].

So, DCO is satisfied if it can find at least one valid SoB.

Warchant commented 5 years ago

@bkeepers @hiimbex ping

Warchant commented 5 years ago

@bkeepers @zeke @lee-dohm @JasonEtco @hiimbex ping

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: