Issue #66 - Fix invalid JSON in bower.json generation

dcodeIO / bcrypt.js

Optimized bcrypt in plain JavaScript with zero dependencies.

Other

3.47k stars 264 forks source link

Issue #66 - Fix invalid JSON in bower.json generation #79

Closed delanni closed 6 years ago

delanni commented 6 years ago

Reason for change?

See Issue #66 A good number of us uses flow for type-checking our javascript code. If this library is sneaking in as a chain dependency, then our flow static checks fail on the invalid .json format. The .json file is used as a template, but it's not noted in the file format, so any checker will fail trying to parse it.

What changed?

post-fixed the file name with a .template suffix
patched the generator to use the new template filename
bumped the patch version

dcodeIO commented 6 years ago

Thanks, looking good!

mjomble commented 6 years ago

Hi, is there an estimate of when version 2.4.4 with this change will be released and published on npm?

mjomble commented 6 years ago

@dcodeIO is anything blocking the release of 2.4.4?

michaelschiff commented 3 years ago

This appears to still be an issue - any update on the release of 2.4.4 ?