This action is using a deprecated action

dcodeIO / setup-node-nvm

Set up your GitHub Actions workflow with a specific version of node.js using nvm.

21 stars 13 forks source link

This action is using a deprecated action #6

Closed ruettenm closed 4 years ago

ruettenm commented 4 years ago

Fist of all thank for this action. It works as expected 👍

But when using it I saw the following warning from github. I guess it makes sense to solve this soon.

The `add-path` command is deprecated and will be disabled soon. 
Please upgrade to using Environment Files. For more information see: 
https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

dcodeIO commented 4 years ago

I've updated the respective dependencies in https://github.com/dcodeIO/setup-node-nvm/pull/7. Can you confirm that the warning did go away (using setup-node-nvm@master)?

ruettenm commented 4 years ago

Yes, thanks :+1:

ljharb commented 3 years ago

To be clear, this means that https://github.blog/changelog/2020-11-09-github-actions-removing-set-env-and-add-path-commands-on-november-16/ will no longer impact this action?

dcodeIO commented 3 years ago

Afaict, yes. It now uses the updated @actions/core module that in turn utilizes the patched mechanism to set environment variables. It was not using the STDOUT related functionality.

ljharb commented 3 years ago

Awesome, thanks. I'm the nvm maintainer, and I was stoked to find this action (which I'm beginning to reuse on hundreds of projects) to help me migrate off of travis.