search

dcoeurjo / pc2vol

1 stars 1 forks source link

Bad voxelisation with version 237c3b8 #3

Closed elombardi2 closed 5 months ago

elombardi2 commented 5 months ago

pc2vol version 237c3b8 produces bad voxelisation, for example with bimba_original_meshlab_normals_v5.xyz.zip.

Command line to reproduce the issue: pc2vol -i bimba_original_meshlab_normals_v5.xyz --gridstep 0.025 -o bimba_original_meshlab_normals_v5.vol

Normal output (pc2vol version 0b7250e): Capture d’écran du 2024-03-28 13-57-34

Broken output (pc2vol version 237c3b8): Capture d’écran du 2024-03-28 14-05-39

dcoeurjo commented 5 months ago

Yes that's "normal". Skipping CGAL implies a better control of the scale factor of point areas. I've refactored the code to explicit this parameter

dcoeurjo commented 5 months ago

ok done, new option: --skipCGALAreas and --factor. Gridstep and factor is now in IMGUI sliders (visu mode)

dcoeurjo commented 5 months ago

I was able to voxelize bimba with the new version (grid step == factor == 0.01)

dcoeurjo commented 5 months ago

It should do the job for uniform density samples. I would have something smarter to do for non-unit points