search

dcohenb / angular-img-fallback

Utility to work with loading images, has fallback-src to handle erros in image loading and loading-src for images loading placeholders
MIT License
146 stars 34 forks source link

minified distro #12

Closed Morriz closed 9 years ago

Morriz commented 9 years ago

Could you please not minify your scripts? Most of us do this in our projects build phase ourselves ;)

dcohenb commented 9 years ago

Feel free to use the unminified code. Although you are not suppose to build external libs only concatenate them. On Jun 19, 2015 19:45, "Maurice Faber" notifications@github.com wrote:

Could you please not minify your scripts? Most of us do this in our projects build phase ourselves ;)

— Reply to this email directly or view it on GitHub https://github.com/dcohenb/angular-img-fallback/issues/12.

Morriz commented 9 years ago

I did. I copied it over your minified version. I don't understand what you mean by "not supposed to". Not being able to step debug through your code is kind of a nono imo ;)

On 19 Jun 2015, at 22:49, Daniel Cohen notifications@github.com wrote:

Feel free to use the unminified code. Although you are not suppose to build external libs only concatenate them. On Jun 19, 2015 19:45, "Maurice Faber" notifications@github.com wrote:

Could you please not minify your scripts? Most of us do this in our projects build phase ourselves ;)

— Reply to this email directly or view it on GitHub https://github.com/dcohenb/angular-img-fallback/issues/12.

— Reply to this email directly or view it on GitHub.

dcohenb commented 9 years ago

Will it help if the minified version will be inside a separated folder named "dist" like all the other libs are doing?

Morriz commented 9 years ago

No, it's nothing to do with that. How you build and concat/minify etc is your business. However, for the outside world you should list the unminified version in bower.json. So they can do it also however they wish ;)

On 23 Jul 2015, at 09:03, Daniel Cohen notifications@github.com wrote:

Will it help if the minified version will be inside a separated folder named "dist" like all the other libs are doing?

— Reply to this email directly or view it on GitHub.

dcohenb commented 9 years ago

Ok, I get what you mean. I replaced the main with the un-minified version. thank you for your feedback!