search

dcohenb / angular-img-fallback

Utility to work with loading images, has fallback-src to handle erros in image loading and loading-src for images loading placeholders
MIT License
146 stars 34 forks source link

When the browser tries to re fetch the image for the second time, fallback-src dont work any more #18

Closed mribichich closed 8 years ago

mribichich commented 8 years ago

Hi, there.

I'm using md-autocomplete fro the material spec, and when you scroll and the item enter the visible part of the view, for some reason the browser tries to fetch the src image, and since the plugin unregisters from the error event, it no longer works

You'll see it in line 15:

element.off('error', errorHanlder);

If you want to, I can try to make a pull request

thanks!

dcohenb commented 8 years ago

@siulung4073 First of all, yes. pull requests are welcome and appreciated. Second, @david-meza PQ should have fixed the issue, can you please confirm?