ImportError: cannot import name 'Markup' from 'flask'

[glopglopoups]

Hello,

Following the evolution of Flask, an error appears on the "flask-markdown" module.

• https://github.com/pallets/flask/pull/5223
• https://github.com/pallets/flask/discussions/5293

Would it be possible to fix the module to fit Flask 3.x. x?

Thank you for your help,

[dcolish]

If you can propose a fix I'm happy to review and approve. I stepped away from this project a long time ago after it was rejected for listing with approved flask plug-ins and left the code for the community.

If it's valuable I'd love to transfer ownership. I'll share an announcement in the readme and in an issue that it will be archived by end of year if no one has time to take it.

Thanks Dan

[SSAdvisor]

How about something like:

try:
    from flask import Markup
except:
    try:
         from markupsafe import Markup
    except:
         raise Exception('Markup module not found')

[SSAdvisor]

Here is what worked for me:

diff --git a/flaskext/markdown.py b/flaskext/markdown.py
index 0059852..413c2fd 100644
--- a/flaskext/markdown.py
+++ b/flaskext/markdown.py
@@ -29,8 +29,15 @@ decorating the extension class with :func:`extend`
 :license: BSD, MIT see LICENSE for more details.
 """
 from __future__ import absolute_import
-from flask import Markup
-from jinja2 import evalcontextfilter, escape
+try:
+    from flask import Markup
+except:
+    from markupsafe import Markup
+try:
+    from jinja2 import evalcontextfilter, escape
+except:
+    from jinja2 import pass_eval_context as evalcontextfilter
+    from markupsafe import escape
 import markdown as md
 from markdown import (
     blockprocessors,

[vanzhiganov]

@dcolish PR https://github.com/dcolish/flask-markdown/pull/26 based on diff from @SSAdvisor