search

dcooney / ajax-load-more

Infinite Scroll with Ajax Load More. The ultimate solution to add infinite scroll functionality to your WordPress powered website.
https://connekthq.com/ajax-load-more/
GNU General Public License v2.0
234 stars 71 forks source link

editorconfig / indention & trailing whitespaces #128

Closed stroebjo closed 7 years ago

stroebjo commented 7 years ago

I noticed there a quite a few trailing spaces, also indention preference is not quite clear to me.

Maybe add an .editorconfig to the project to reduce "change noise" as in commit wich only change indention/whitespace/etc.?

EditorConfig can be used to set preferences for indention and whitespace handling to the projects wishes.

dcooney commented 7 years ago

Agree, driving me nuts.

stroebjo commented 7 years ago

Are you defining one or are you open to a pull request? Something like is is probably a good Idea: https://github.com/pfefferle/.editorconfigs/blob/master/php-psr-2/.editorconfig :)

dcooney commented 7 years ago

I'm going to add one to the new version i'm releasing this weekend. Im under the impression adding an editor config will NOT format what has already been coded?

True?

stroebjo commented 7 years ago

Yes, existing code will not be affected until you save/fix it.

But there are tools like eclint which try to fix existing code according to the given .editorconfig. I have no experience using it, but maybe it's worth a try?