dcorking / google-wave-resources

Automatically exported from code.google.com/p/google-wave-resources
0 stars 0 forks source link

Extension installers can crash waves. #715

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
An extension manifest that doesn't validate in the schema crashes a wave.

Here is an example:
http://www.voizle.com/LuckyYouInstaller.xml
Rejected invalid operation: ViolationCollector[3: schema violation: element 
type menuHook does 
not permit subelement type participant at original document position 0 / 
resulting document 
position 5

Other manifests that crash waves:

http://www.wave.to/botinstaller/rssybot_bot_installer.xml
because the <author> element has an "email" attribute.

http://home.lehnerstudios.com:4000/wave/crashy-installer.xml
because there is a <crash/> element. (just for demo purposes, of course)

Because I have one of these extensions installed, my Extension Settings wave 
crashes whenever I 
open it.  This is annoying because then I can't uninstall it.

It would be great if the wave client would not allow insertion of extension 
manifests that are not 
valid by the schema, and would not crash when it encounters one.

Original issue reported on code.google.com by celehner1 on 1 Apr 2010 at 4:14

GoogleCodeExporter commented 9 years ago
We've been looking into this, thanks for filing.

Original comment by pamela.fox on 1 Apr 2010 at 7:54

GoogleCodeExporter commented 9 years ago
Great, thanks!

Original comment by celehner1 on 1 Apr 2010 at 8:33

GoogleCodeExporter commented 9 years ago
This was fixed in the latest server release.

Original comment by pamela.fox on 29 Apr 2010 at 10:22

GoogleCodeExporter commented 9 years ago
Awesome.

Original comment by celehner1 on 30 Apr 2010 at 12:52