dcorking / google-wave-resources

Automatically exported from code.google.com/p/google-wave-resources
0 stars 0 forks source link

Some characters in document modify operations break wave for robots #812

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Hello,

I'm running into a bug lately, that my robot stops listening to Waves
after it tries to post some OT (and fail in the middle it seems).

Here is an example.

* I trigger my Flammard bot (flammard@appspot.com) to respond with some text.
* I can see in my GAE logs that the text is applied to the OT without
any problems, there is no error whatsoever.
* The OT begins to be applied to the Wave (e.g. it creates a new
blip), but the text (usually quite big when the bug happens) is not
applied.
* After this, the bot does not respond to any new events from this
Wave, even if I remove it and add it again.

Attached are the OT that the robot got and sent.

Original issue reported on code.google.com by raph...@gmail.com on 24 Jun 2010 at 2:59

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Sorry, wrong attachment, here comes the outgoing OT.

Original comment by raph...@gmail.com on 24 Jun 2010 at 3:05

Attachments:

GoogleCodeExporter commented 9 years ago
Can you make the sample wave public and link us to it? That will make it easier 
to see what goes wrong with the wave.

Original comment by pamela.fox on 25 Jun 2010 at 1:01

GoogleCodeExporter commented 9 years ago
This is the wave : 
https://wave.google.com/a/wavesandbox.com/waveref/wavesandbox.com/w+4Qb9dpv2A

Original comment by raph...@gmail.com on 25 Jun 2010 at 5:55

GoogleCodeExporter commented 9 years ago
It actually seems to be linked to unicode issues. The wave I posted showed the 
problem when the robot was supposed to post greek text. I was able to reproduce 
with hebrew text, too.

If that makes it easier, I could show you the problem live in a wave, just let 
me know.

Original comment by raph...@gmail.com on 26 Jun 2010 at 12:24

GoogleCodeExporter commented 9 years ago
it seems that i encounter the same issue, not sure if its related to OT, i'm 
not an expert in that. My bot stops seeing events in a wave when i send it a 
\002 char ( \002 is bold in IRC, the bot relays between IRC and Wave).

I made a wave to show this... its at  
https://wave.google.com/wave/#restored:wave:googlewave.com%252Fw%252BCHBUgKwLR

Original comment by bthate on 30 Jun 2010 at 6:42

GoogleCodeExporter commented 9 years ago
Regarding the Greek/Hebrew - it works okay for me. I think the problem with 
your operations is perhaps the "\t" character, which is known to break waves.

I have replicated the issue with the IRC character breaking the wave.

Original comment by pamela.fox on 23 Jul 2010 at 5:47

GoogleCodeExporter commented 9 years ago
Ah OK. It doesn't seem like the wave is broken though. I can still edit it, 
it's just that the bot stops listening to events.

Original comment by raph...@gmail.com on 23 Jul 2010 at 6:41