search

dcorking / google-wave-resources

Automatically exported from code.google.com/p/google-wave-resources
0 stars 0 forks source link

wave.document.modify with carriage return in content breaks the wave #831

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Using the Data API I call wave.document.modify with "modifyHow": "REPLACE" and 
a raw carriage return (ASCII 13, '\r') in the content. This results in an empty 
blip appearing in the full Wave client. When the wave is refreshed from the 
Data API however, the modified content appears in the created blip.

The more significant issue is that the two views of the wave now seem to be 
decoupled. All modifications to the wave (replies, edits, adding participants, 
etc) via the Data API are not reflected in the full client and vice-versa.

eatenbyagrue.org!w+3Kb6k8eyM. I created the wave, made a reply from the full 
client and from the Data API, then sent a second reply from the Data API 
containing a carriage return. I then sent a reply from each side and noted that 
they don't appear to each other.

Attached is screenshots of the wave display from the full client and from 
ripple (application using the Data API, see http://eatenbyagrue.org/a/ripple), 
and a dump of the wave state as returned by fetchWave (in Perl Data::Dumper 
format, which is analogous to JSON and should be readble).

Original issue reported on code.google.com by eatenbya...@gmail.com on 3 Jul 2010 at 1:16

Attachments:

GoogleCodeExporter commented 9 years ago 
I've also heard that if you mark a participant as read only and you still 
attempt to do modifications on the wave via the Data API (you get an error) 
then re-add access for that participant, the wave gets "decoupled" in the same 
way. However I have not tested this and it may not be related.

Original comment by eatenbya...@gmail.com on 3 Jul 2010 at 1:18

GoogleCodeExporter commented 9 years ago 
More exhaustive testing has been done. It appears that all control characters 
_except_ LF break the wave. Specifically, in the single-byte range characters 
0-9, 11-31 and 127-159 all cause a break. A limited number of Unicode control 
characters were also tested with the same result.

Original comment by eatenbya...@gmail.com on 3 Jul 2010 at 10:11

GoogleCodeExporter commented 9 years ago 
Problem described in #1 is probably the same as 
http://code.google.com/p/google-wave-resources/issues/detail?id=760.

Original comment by eatenbya...@gmail.com on 4 Jul 2010 at 9:40

GoogleCodeExporter commented 9 years ago 
I have replicated this. It is related to issue 812, which reports that other 
characters have the same effect.

Original comment by pamela.fox on 23 Jul 2010 at 5:48