search

dcortes92 / vs-freemarker

FreeMarker language colorization extension for Visual Studio Code
MIT License
25 stars 14 forks source link

Fix readme #8

Closed dcortes92 closed 7 years ago

dcortes92 commented 7 years ago

There's a problem with the readme shown in the marketplace. Screenshot attached.

readme-issue
vinlos commented 7 years ago

hello Daniel,

thank you for the merge! I see the issue. I'd try to remove the name of the language 'freemarker' after the 3 characters ``` and I'd try to replace it with 'xml' or 'html'. Unfortunately I cannot test the behavior because VsCode reads the ReadMe markdown directly from your GitHub project.

In any case it's a VSCode issue, since GitHub is able to render it correctly.

Have a nice day, Vincenzo

Il giorno gio 2 feb 2017 alle ore 19:11 Daniel Cortes < notifications@github.com> ha scritto:

There's a problem with the readme shown in the marketplace. Screenshot attached.

[image: readme-issue] https://cloud.githubusercontent.com/assets/3781536/22562090/b62a8852-e940-11e6-912e-f8a93b124bda.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dcortes92/vs-freemarker/issues/8, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUQW8KLZSuHYbk9-WoZ2FuS2WIuzof1ks5rYhxqgaJpZM4L1cwS .

dcortes92 commented 7 years ago

Hi @vinlos, you're right it was a VSCode issue. But I was able to fix it anyway, you can check how I did it in the referenced commit above 🙂

Thanks,

Daniel

vinlos commented 7 years ago

Perfect! Nice workaround!

Il giorno ven 3 feb 2017 alle ore 19:19 Daniel Cortes < notifications@github.com> ha scritto:

Hi @vinlos https://github.com/vinlos, you're right it was a VSCode issue. But I was able to fix it anyway, you can check how I did it in the referenced commit above 🙂

Thanks,

Daniel

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/dcortes92/vs-freemarker/issues/8#issuecomment-277321915, or mute the thread https://github.com/notifications/unsubscribe-auth/ABUQW3wcKOUl6ezoOz4HGvBgV5maVc9Oks5rY2-5gaJpZM4L1cwS .