dcos / dcos-e2e

Spin up and manage DC/OS clusters in test environments
Apache License 2.0
60 stars 21 forks source link

Suggest to loosen the dependency on halo #1911

Open Agnes-U opened 1 year ago

Agnes-U commented 1 year ago

Hi, your project dcos-e2e(commit id: ab7c4bfd58872f458e5766fff01ca74322441065) requires "halo==0.0.29" in its dependency. After analyzing the source code, we found that the following versions of halo can also be suitable, i.e., halo 0.0.28, since all functions that you directly (5 APIs: halo.halo.Halo.start, halo.halo.Halo.succeed, halo.halo.Halo.stop, halo.halo.Halo.fail, halo.halo.Halo.init) or indirectly (propagate to 13 halo's internal APIs and 9 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on halo from "halo==0.0.29" to "halo>=0.0.28,<=0.0.29". This will improve the applicability of dcos-e2e and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on halo?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?