search

dcos / dcos-ui

The UI for The Datacenter Operating System
https://dcos.io/
Apache License 2.0
256 stars 81 forks source link

Do not prevent abolute path in container secret #4977

Closed janisz closed 3 years ago

janisz commented 3 years ago

Closes: https://jira.d2iq.com/browse/D2IQ-72705

Testing

Trade-offs

Dependencies

Screenshots

Things to consider

pierrebeitz commented 3 years ago

please have a look at the "Lint" section at https://github.com/dcos/dcos-ui/pull/4945#issuecomment-706407307 again. we format with prettier.js

please let the commit message state that this is a fix for out generated changelogs. e.g. fix: i fixed stuff

janisz commented 3 years ago

Fixed it

What I miss is section in readme or contribute.md with information how to setup up project git hooks to lint commits and code on git commit

pierrebeitz commented 3 years ago

those hooks are meant to be setup via npm's preinstall. that in turn seems to call ./scripts/pre-install which should install those hooks for you. i don't have a prettier-check on precommit though (and i think that's fine).

mesosphere-ci commented 3 years ago

:tada: This PR is included in version 6.1.15 :tada:

The release is available on:

Your semantic-release bot :package::rocket: