search

dcosson / vagrant-unison2

Vagrant plugin to sync local files to VM using Unison over SSH
MIT License
50 stars 8 forks source link

Notify upstream of Airbnb changes #22

Closed justjake closed 7 years ago

justjake commented 7 years ago

Hey @dcosson, I've made some changes to vagrant-unison2 over the past few months on our internal fork of this project at Airbnb. I'm opening this PR to give you a heads-up, and show you all the changes I've made at once, instead of spamming you with a PR for each of these commits.

Some of my changes are Airbnb-specific, so it's best to review this PR commit-by-commit. If you would like to merge any of these changes, let me know! I'm happy to write README documentation each commit, and then open separate PRs.

dcosson commented 7 years ago

Awesome! Sorry for the delay, this looks pretty good so far. I'll do a bit more review & test it out tonight

dcosson commented 7 years ago

Sorry for the delay! This is great though.

And I can imagine the use_ssh_agent arg being useful to others as well, I'm fine merging it since it still works with the regular private_key_path by default.