search

dcostinett / and-bookworm

Automatically exported from code.google.com/p/and-bookworm
0 stars 0 forks source link

Review simon branch (OpenLibrary and Composite data sources) #93

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Purpose of code changes on this branch:

When reviewing my code changes, please focus on:

After the review, I'll merge this branch into:
/trunk

Original issue reported on code.google.com by charlie....@gmail.com on 1 Aug 2010 at 3:42

GoogleCodeExporter commented 9 years ago 
At first blush the OpenLibraryDataSource looks very nice (thanks!). The 
CompoundDataSource looks good too (though it might be nice to be able to set 
the order as a preference if using the compound)? 

I can't tell if these are used by setting a pref and switchable in the app 
though? I'll look at it more and see if I can figure it out (just running the 
app, I can't switch -- I'll try to wire these in).

Original comment by charlie....@gmail.com on 1 Aug 2010 at 10:03