search

dcourtois / premake-qt

Premake module adding support for Qt to actions (Visual Studio, makefiles, etc.)
Do What The F*ck You Want To Public License
45 stars 11 forks source link

Include path spam #1

Closed TurkeyMan closed 9 years ago

TurkeyMan commented 9 years ago

Why this line: https://github.com/dcourtois/premake-qt/blob/master/qt.lua#L185 ?? I don't think moc or qrc ever generate header files do they? I don't think this is necessary...?

dcourtois commented 9 years ago

uic does. I should check if the includedir is already added before adding it again though, thanks for the report, I'll try to fix this during the day !

dcourtois commented 9 years ago

I was just out of bed when I replied, now that I'm awake, I see that the includedir is done only once for each config (I thought it was done for each file, when I replied this morning)

When you say it spams include path, could you elaborate ? (I will add a test to only add this include path when a .ui file is detected, but I'd like to know what the spam is)

TurkeyMan commented 9 years ago

Oh okay. I'm using Qt5, so no uic. Perhaps also only emit this line if there are any headers emitted?

TurkeyMan commented 9 years ago

Yeah sorry, 'spam' in this case should read 'appears once where zero times would be preferable' ;)

dcourtois commented 9 years ago

Yes, that's what I thought, but I wanted to be sure :) And yes, I already pushed a commit that only add the include path when there is a .ui file, so now it should not be added in your case :)