Closed galou closed 6 years ago
thank you @galou for this contribution!! Much appreciated!
Also changed the text of Ex029_Braille.py
from FreeCAD
to CadQuery
. Everybody would have noticed by himself, I guess :smile:.
@adam-urbanczyk Other than the example changes, has this PR been addressed now?
@galou Now that #224 has been merged there are a couple of conflicts with this PR (exports.py and TestExporters.py). I think that the intent of your changes to those files has been addressed in #224. Would it be possible for you to pull master into your branch and resolve those conflicts so that we can merge this?
@galou If you're not already working on this, I think I'll try to merge the changes manually within the next week. I appreciate your contributions, and want to make sure they get pulled in.
The changes to the braille example have been integrated into master in commit 22fabda8d8de63ae19d82e34934c29b5f29940c1
@galou Your changes (with some necessary modifications to resolve conflicts) have been pulled into master in commit 5c7553870294d94ba2e596d79180ce1051cebab7
Sorry about the mess on this. In the push for Python 3 compatibility we ended up with PRs that overlapped yours. I'm going to go ahead and close this since the content of the PR has been pulled in another way.
Thank you for these contributions.
I'm sorry that I didn't have the time to look at this lately (and I forgot about it too when I could have found the time). I'll try to find some time over the weekend.
Everything look to work as it should, thanks for the integration!
Ex029_Braille.py now works again. Prepare for Python 3. All test pass except testAMF, where, I suppose, the test fails because of lacking of support in xml.etree.