dcowden / cadquery

CadQuery-- a parametric cad script framework
Other
432 stars 56 forks source link

Improve unicode support #222

Closed galou closed 6 years ago

galou commented 6 years ago

Ex029_Braille.py now works again. Prepare for Python 3. All test pass except testAMF, where, I suppose, the test fails because of lacking of support in xml.etree.

dcowden commented 6 years ago

thank you @galou for this contribution!! Much appreciated!

galou commented 6 years ago

Also changed the text of Ex029_Braille.py from FreeCAD to CadQuery. Everybody would have noticed by himself, I guess :smile:.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.06%) to 87.117% when pulling ea858fad52739049d606165ce9ba19b7bcfc5c45 on galou:improve_unicode into 97521c5c46d5e0473b6b3823da3be251feb67387 on dcowden:master.

jmwright commented 6 years ago

@adam-urbanczyk Other than the example changes, has this PR been addressed now?

jmwright commented 6 years ago

@galou Now that #224 has been merged there are a couple of conflicts with this PR (exports.py and TestExporters.py). I think that the intent of your changes to those files has been addressed in #224. Would it be possible for you to pull master into your branch and resolve those conflicts so that we can merge this?

jmwright commented 6 years ago

@galou If you're not already working on this, I think I'll try to merge the changes manually within the next week. I appreciate your contributions, and want to make sure they get pulled in.

jmwright commented 6 years ago

The changes to the braille example have been integrated into master in commit 22fabda8d8de63ae19d82e34934c29b5f29940c1

jmwright commented 6 years ago

@galou Your changes (with some necessary modifications to resolve conflicts) have been pulled into master in commit 5c7553870294d94ba2e596d79180ce1051cebab7

Sorry about the mess on this. In the push for Python 3 compatibility we ended up with PRs that overlapped yours. I'm going to go ahead and close this since the content of the PR has been pulled in another way.

Thank you for these contributions.

galou commented 6 years ago

I'm sorry that I didn't have the time to look at this lately (and I forgot about it too when I could have found the time). I'll try to find some time over the weekend.

galou commented 6 years ago

Everything look to work as it should, thanks for the integration!