dcowden / cadquery

CadQuery-- a parametric cad script framework
Other
432 stars 56 forks source link

Dont install freecad-doc in the Travis build #256

Closed gntech closed 6 years ago

gntech commented 6 years ago

The freecad-doc package download weighs in at about 150 MB and adds several minutes to the travis build time for no purpose (not that I know of that is :smile: ).

AppVeyorBot commented 6 years ago

:x: Build cadquery 1.0.27 failed (commit https://github.com/dcowden/cadquery/commit/a190cc3009 by @gntech)

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 92.252% when pulling 1146a5966fefeec4511d3e39b340d606f46d91f7 on gntech:speed-up-travis into 491ec9f659a3cd8d5f85b80e99d0c1cff9ac0b02 on dcowden:master.

AppVeyorBot commented 6 years ago

:x: Build cadquery 1.0.28 failed (commit https://github.com/dcowden/cadquery/commit/a190cc3009 by @gntech)

jmwright commented 6 years ago

This build seems to be failing in both Travis and AppVeyor, but both seem due to the Anaconda setup. @adam-urbanczyk Do you have any thoughts on what might be happening? In AppVeyor the FreeCAD package seems to be inaccessible. In Travis it says that the freecad_cq3 environment is not available.

adam-urbanczyk commented 6 years ago

Yes, looking into this (I bet this is related to cleaning up of the repo after release). Time to set up our own channel with testing packages I guess.

On Thu, Apr 26, 2018, 10:58 PM Jeremy Wright notifications@github.com wrote:

This build seems to be failing in both Travis and AppVeyor, but both seem due to the Anaconda setup. @adam-urbanczyk https://github.com/adam-urbanczyk Do you have any thoughts on what might be happening? In AppVeyor the FreeCAD package seems to be inaccessible. In Travis it says that the freecad_cq3 environment is not available.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dcowden/cadquery/pull/256#issuecomment-384786858, or mute the thread https://github.com/notifications/unsubscribe-auth/ANVXYqpTwhA1BHQdAeuvmJx7s5S5JTarks5tsjT1gaJpZM4Tnl-U .

AppVeyorBot commented 6 years ago

:white_check_mark: Build cadquery 1.0.36 completed (commit https://github.com/dcowden/cadquery/commit/985a383d38 by @gntech)

jmwright commented 6 years ago

@gntech Could you do a rebase on this like you did for #257 so we can merge it?

@dcowden You didn't have freecad-doc included because you needed it for the Sphinx docs generation scripts did you?

dcowden commented 6 years ago

@jmwright I don't think so, but it's been a while so I don't really trust my memory

gntech commented 6 years ago

@jmwright I have rebased this pull request now

AppVeyorBot commented 6 years ago

:white_check_mark: Build cadquery 1.0.37 completed (commit https://github.com/dcowden/cadquery/commit/364ff187f2 by @gntech)

codecov-io commented 6 years ago

Codecov Report

Merging #256 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #256   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          10       10           
  Lines        2207     2207           
=======================================
  Hits         2048     2048           
  Misses        159      159

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 491ec9f...1146a59. Read the comment docs.

jmwright commented 6 years ago

@gntech Thanks!