search

dcowden / cadquery

CadQuery-- a parametric cad script framework
Other
432 stars 56 forks source link

toWorldCoords Documentation #42

Closed jmwright closed 9 years ago

jmwright commented 10 years ago

The toWorldCoords documentation says that it returns a 3 tuple, but when I print what's returned I see that it's a Vector and FreeCAD complains that it's a Vector, not a Base.Vector.

http://parametricparts.com/docs/classreference.html?highlight=toworldcoords#cadfile.cadutils.cadquery.Plane.toWorldCoords

dcowden commented 10 years ago

Hmmm.. Well that doesn't seem right... On Oct 16, 2014 11:07 PM, "Jeremy Wright" notifications@github.com wrote:

The toWorldCoords documentation says that it returns a 3 tuple, but when I print what's returned I see that it's a Vector and FreeCAD complains that it's a Vector, not a Base.Vector.

http://parametricparts.com/docs/classreference.html?highlight=toworldcoords#cadfile.cadutils.cadquery.Plane.toWorldCoords

— Reply to this email directly or view it on GitHub https://github.com/dcowden/cadquery/issues/42.

jmwright commented 9 years ago

The source code for Plane.toWorldCoords() in cadquery/freecad_impl/geom.py has the following line.

return Vector(self.rG.multiply(v.wrapped))

I'm thinking I should just go in and fix the doc string. I'll do that unless there's an objection.

dcowden commented 9 years ago

No objection... On Oct 22, 2014 11:16 PM, "Jeremy Wright" notifications@github.com wrote:

The source code for Plane.toWorldCoords() in cadquery/freecad_impl/geom.py has the following line.

return Vector(self.rG.multiply(v.wrapped))

I'm thinking I should just go in and fix the doc string. I'll do that unless there's an objection.

— Reply to this email directly or view it on GitHub https://github.com/dcowden/cadquery/issues/42#issuecomment-60187714.

jmwright commented 9 years ago

This is addressed in pull request #44

jmwright commented 9 years ago

This has been merged from pull request #44