search

dcoxall / dcoxall-wordpress

Puppet NGINX, PHP-FPM and MySQL configured for Wordpress
5 stars 2 forks source link

Can you add curl support for PHP? #1

Closed johnjelinek closed 10 years ago

johnjelinek commented 10 years ago

I'm not familiar with puppet yet, otherwise I'd just send a pull request.

johnjelinek commented 10 years ago

Steps to install curl:

johnjelinek commented 10 years ago

I did notice that the php module you're dependent on seems to claim curl support: https://github.com/saz/puppet-php/blob/master/EXAMPLE#L50, however when I executed puppet, no change. I had to repeat those steps again. Thoughts?

dcoxall commented 10 years ago

Thanks for opening this... I will have a look today. What is the best way of checking this has worked?

johnjelinek commented 10 years ago

If you check phpinfo() you'll see curl in the output, otherwise, it won't be there. On Dec 17, 2013 3:50 AM, "Darren Coxall" notifications@github.com wrote:

Thanks for opening this... I will have a look today. What is the best way of checking this has worked?

— Reply to this email directly or view it on GitHubhttps://github.com/FreakyDazio/dcoxall-wordpress/issues/1#issuecomment-30738046 .

dcoxall commented 10 years ago

I now explicitly include curl and have checked the output from phpinfo and can confirm it includes curl.

johnjelinek commented 10 years ago

Hmm, interesting. I was going to submit a pull request with just the change you made, but I noticed that it didn't supply the php.ini change that was necessary situationally. I still had to do echo extension=curl.so >> /etc/php5/fpm/php.ini. Did this part work for you?

dcoxall commented 10 years ago

I didn't need that line. With the change I made I just made sure it ran and then created a file with <?php phpinfo(); ?> and visited that page. It included the curl section.

johnjelinek commented 10 years ago

Cool, I'll try it out again :). On Dec 17, 2013 10:49 AM, "Darren Coxall" notifications@github.com wrote:

I didn't need that line. With the change I made I just made sure it ran and then created a file with <?php phpinfo(); ?> and visited that page. It included the curl section.

— Reply to this email directly or view it on GitHubhttps://github.com/FreakyDazio/dcoxall-wordpress/issues/1#issuecomment-30767863 .

johnjelinek commented 10 years ago

ok, confirmed, works for me :)