dcramer / django-uuidfield

A UUIDField for Django
BSD 3-Clause "New" or "Revised" License
262 stars 115 forks source link

fix get_db_prep_value when value is unicode #29

Closed zebuline closed 9 years ago

luto commented 9 years ago

This PR really boils down to this line:

- if isinstance(value, str):
+ if isinstance(value, basestring):

The hyphenate-issue was already fixed (see #36).

Could you please re-submit a PR only contaning this change, since this PR has conflicts or tell me if this issue has been resolved?

jaredlewis commented 9 years ago

Any timetable on getting this merged? This is a flaw and is occurring for me in python 3.4

micahhausler commented 9 years ago

Rather than using basestring, can this use six.string_types?

zebuline commented 9 years ago

New PR here: https://github.com/dcramer/django-uuidfield/pull/45