dcramer / django-uuidfield

A UUIDField for Django

BSD 3-Clause "New" or "Revised" License

262 stars 115 forks source link

Closed julienaubert closed 9 years ago

julienaubert commented 10 years ago

I started from dominicrodger's PR, and did:

Note: I was not able to use runtests.py (it is not used by tox/.travis.yml) - perhaps that one should be removed? (in favour of the setup.py test).

Note: seems some tests are missing, in particular, these methods are not covered at all:

and a test using uuid version1 should probably exist as well.

julienaubert commented 10 years ago

Updated: added tests so that value_to_string, formfield and uuid-version1 is covered.

@dcramer, thankful if could be merged in and released - let me know if you have any concerns.

julienaubert commented 10 years ago

@dcramer - also, would recommend you login to http://travis-ci.org/ and https://coveralls.io/ to enable this repo. (benefits: you get badges showing up-to-date build/coverage in the README: https://github.com/julienaubert/django-uuidfield/tree/python3, and in PR:s you see if the PR passes on travis and can be merged in).

julienaubert commented 10 years ago

Can this PR go in?

dcramer commented 10 years ago

I haven't really had time to review this and it's a fairly significant change. I'll try to take a look soon, but for now i've enabled Travis

julienaubert commented 10 years ago

OK, thanks!

jleclanche commented 10 years ago

@dcramer @julienaubert Any news?

luto commented 9 years ago

34 got merged and this PR has conflicts.

I am closing this for now, feel free to re-submit what you think is missing. Thank you!