search

dcramer / hass-luxor

FXLuminaire Luxor integration for Home Assistant
MIT License
9 stars 9 forks source link

Fix `manifest.json` to comply with current requirements. #4

Closed sdwilsh closed 2 years ago

sdwilsh commented 2 years ago

Sorts and updates manifest.json to bring it up to spec. There have been changes to the manifest.json file since this integration was created.

I have not tested this, but this probably addresses what is raised in #3.

sdwilsh commented 2 years ago

This will certainly fix the hassfest issues that stopped the cron job from running.

dcramer commented 2 years ago

Thanks! Meant to f/u here and it got lost in my inbox.

I have noticed mixed results on this working lately, but have been so busy with summer I haven't had a chance to debug.

dcramer commented 2 years ago

Looks like the hacs validation is failing - possible thats out of date/wrong though?

sdwilsh commented 2 years ago

I'll play around with this tonight and get it passing.

The days are getting shorter, and I want to get my lights a bit more automated :)

On Tue, Sep 6, 2022, 10:43 David Cramer @.***> wrote:

Looks like the hacs validation is failing - possible thats out of date/wrong though?

— Reply to this email directly, view it on GitHub https://github.com/dcramer/hass-luxor/pull/4#issuecomment-1238467900, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFAJWTOGALXHSA5HQZAWX3V457FHANCNFSM6AAAAAAQA4PSG4 . You are receiving this because you authored the thread.Message ID: @.***>

sdwilsh commented 2 years ago

I'll address the unit tests in a different PR later, but this should address the issue that the linter was getting hung up on.

sdwilsh commented 2 years ago

hassfest is now passing :)

If it's alright with you, I'd like to get this merged, and then I'll fix up tests in a new PR. I should be able to work on that tonight. The plus side is that I shouldn't need to have my CI runs approved once this is merged because I won't be a first time contributor.

dcramer commented 2 years ago

@sdwilsh yeah thats fine - i wont be able to test on my system til late this month anyways