search

dcramer / hass-luxor

FXLuminaire Luxor integration for Home Assistant
MIT License
9 stars 9 forks source link

Update Test Environment #5

Open sdwilsh opened 2 years ago

sdwilsh commented 2 years ago

This has GitHub Actions run with Python 3.9 and 3.10, the two versions that are supported by Home Assistant currently. It also updates pytest-homeassistant-custom-component to something much newer such that it actually finds working dependencies.

sdwilsh commented 2 years ago

The tests are still going to fail, as there are two fixtures that they reference that simply do not exist. I'm not going to have time for a few days to debug them, but I've started some of that work in sdwilsh/fix-tests.

dcramer commented 2 years ago

@sdwilsh was that always the case? been so long since I wrote this, just kind of assumed the tests are valid

sdwilsh commented 2 years ago

It looks like you nuked the two missing fixtures in 197697ba35adfd3a6efb4af5c59f13cc36cc459c, and that was the most recent commit to that directory, so it's never worked with GitHub code. Maybe you had it working locally (I've certainly done that before).

I can setup the integration now, and it finds the device, but no entities so there's more to debug with this. I'll try to get tests for whatever I get working so we don't break it in the future.

dcramer commented 2 years ago

@sdwilsh which system do you have? model number or something? i will have to check mine but when I was writing this I remember there being multiple systems

fwiw I believe I modeled the API somewhat dry initially off of another project, specifically this https://github.com/tagyoureit/homebridge-luxor

sdwilsh commented 2 years ago

I honestly don't know, and their app isn't telling me anything terribly useful, I think (it says lux2 and what I assume is a serial number after a dash). I don't see anything helpful in emails with the contractor who installed it either, but I swear we discussed options somewhere.

Realistically, I'm not going to be able to dive into this for about two weeks, looking at my calendar.