search

dcramer / hass-luxor

FXLuminaire Luxor integration for Home Assistant
MIT License
9 stars 9 forks source link

Fix device entities and update version #8

Closed dronenb closed 1 year ago

dronenb commented 1 year ago

Fix #6

tfasz commented 1 year ago

Interested in trying this out - any update on if this will be merged?

briancmpbll commented 1 year ago

I pulled these changes into my HASS instance and I now get devices for each group and scene on the luxor. They don't seem to update consistently when the groups are turned on outside of home assistant though.

dcramer commented 1 year ago

Thanks for the ping! Not sure why I lost this. Do we know if there are differing versions of th Luxor controllers and/or firmware that might be related at all? We're doing some construction so I can't actually test anything, but I have also noticed extremely flakey behavior (on top of some changes to HASS tha thave broken the integration). I will say the flakey behavior has always somewhat been present, and I think is just a property of how the Luxor controllers work.

dcramer commented 1 year ago

Also, I'm going to go ahead and merge this given @briancmpbll has at least verified its not completely broken, but if folks report breakage we can consider some kind of version branding and support both paths.