search

dcramer / peated

https://peated.com
Apache License 2.0
63 stars 13 forks source link

Refactor deploy workflow to use booleans #131

Closed dcramer closed 8 months ago

dcramer commented 8 months ago

Noticed some issues w/ the == 'true' comparisons when working on another workflow file in a diff repo. Not sure if nocache was working correclty or not, and it seems to vary based on where you reference the checks.

I did confirm that these did get skipped in a number of situations, so not entirely sure what was different between that project and this. May not land this, but I want to test the change.s

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (431e3d8) 81.84% compared to head (0050c6b) 81.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #131 +/- ## ======================================= Coverage 81.84% 81.84% ======================================= Files 173 173 Lines 11778 11778 Branches 993 993 ======================================= Hits 9640 9640 Misses 2138 2138 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 8 months ago

Alright appears to work