dcramer / peated

https://peated.com
Apache License 2.0
59 stars 12 forks source link

Update Sentry SDK to v8.0.0-alpha.4 #147

Closed mydea closed 3 months ago

mydea commented 4 months ago

This updates to the prerelease of the new v8 SDK, which is OpenTelemetry powered under the hood for @sentry/node and @sentry/remix.

I did some local testing where it seemed to work fine, as far as I can tell, but I haven't spent too much time yet checking it out.

mydea commented 4 months ago

Hmm, there seems to be some ESM/Build issue with profiling-node, we'll look into it...!

dcramer commented 4 months ago

@mydea yeah that happened in latest experimenta-nodel builds too fwiw

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 77.77778% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 81.69%. Comparing base (cb3cb97) to head (dd6f16a). Report is 1 commits behind head on main.

:exclamation: Current head dd6f16a differs from pull request most recent head 65a61a0. Consider uploading reports for the commit 65a61a0 to get more accurate results

Files Patch % Lines
apps/server/src/sentryPlugin.ts 71.42% 12 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #147 +/- ## ========================================== - Coverage 81.73% 81.69% -0.04% ========================================== Files 179 179 Lines 12486 12478 -8 Branches 1073 1072 -1 ========================================== - Hits 10205 10194 -11 - Misses 2281 2284 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mydea commented 4 months ago

OK, I fixed everything I believe, but codecov CI is failing now 😬

mydea commented 4 months ago

Actually, we need to bump spotlight too to be v8 compatible (that should be easy and will work in v7 & v8 both, just need to cut a release - we'll do that today)

Lms24 commented 3 months ago

Today we released @spotlight/spotlight@2.0.0-alpha.1 which is compatible with Sentry SDK v8 and >=7.99.0. I just bumped spotlight to the new alpha and (after also adding an additional guard to the feedback modal injection) now, things seem to work! 🎉

dcramer commented 3 months ago

🏁