dcramer / peated

https://peated.com
Apache License 2.0
63 stars 13 forks source link

Various improvements to Add Bottle flow #161

Closed dcramer closed 5 months ago

dcramer commented 5 months ago
dcramer commented 5 months ago

There's still an annoying amount of brittleness in the UI. I was able to collapse some duplication, but more work is needed here.

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 83.36756% with 81 lines in your changes are missing coverage. Please review.

Project coverage is 77.77%. Comparing base (c57fcd3) to head (d92c3bf). Report is 2 commits behind head on main.

Files Patch % Lines
apps/server/src/trpc/routes/entityList.ts 60.16% 47 Missing :warning:
apps/server/src/trpc/routes/entityUpdate.ts 60.00% 14 Missing :warning:
apps/server/src/trpc/routes/bottleUpdate.ts 87.50% 6 Missing :warning:
apps/server/src/trpc/routes/bottlePreview.ts 95.37% 5 Missing :warning:
apps/server/src/trpc/routes/entityAliasList.ts 86.48% 5 Missing :warning:
apps/server/src/trpc/routes/entityCreate.ts 69.23% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================== + Coverage 77.74% 77.77% +0.02% ========================================== Files 190 198 +8 Lines 13949 14554 +605 Branches 1180 1231 +51 ========================================== + Hits 10845 11319 +474 - Misses 3104 3235 +131 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.