search

dcramer / peated

https://peated.com
Apache License 2.0
59 stars 12 forks source link

Switch to Sentry trace continuation API #164

Closed dcramer closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 8.47458% with 54 lines in your changes are missing coverage. Please review.

Project coverage is 77.76%. Comparing base (cc0300b) to head (c6dc5b5).

:exclamation: Current head c6dc5b5 differs from pull request most recent head 2f192a2. Consider uploading reports for the commit 2f192a2 to get more accurate results

:white_check_mark: All tests successful. No failed tests found :relaxed:

Files Patch % Lines
apps/server/src/jobs/client.ts 8.47% 54 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #164 +/- ## ========================================== + Coverage 77.73% 77.76% +0.02% ========================================== Files 198 198 Lines 14573 14574 +1 Branches 1233 1233 ========================================== + Hits 11329 11334 +5 + Misses 3244 3240 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 3 months ago

This appears to be working, but need to yet validate that in a typical async job (e.g. a cron job) its isolating trace IDs.

dcramer commented 3 months ago

Need to verify the otel implementation previously worked and that the SDK changes wont break someone having manually instrumented their own trace continuation.