search

dcramer / peated

https://peated.com
Apache License 2.0
64 stars 13 forks source link

Initial Next.js frontend #176

Closed dcramer closed 5 months ago

dcramer commented 5 months ago

This adds a POC for a Next.js frontend, converting all non-admin routes over.

There's a variety of improvements that will need backported to Remix if we dont move forward with this, such as the country page, the entities lists, etc.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.21%. Comparing base (3ba9901) to head (fff2084). Report is 1 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #176 +/- ## ======================================= Coverage 77.21% 77.21% ======================================= Files 208 208 Lines 15266 15266 Branches 1271 1271 ======================================= Hits 11788 11788 Misses 3478 3478 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 5 months ago

Going to merge the RPC changes into main as they're easy to pull out of this.

dcramer commented 5 months ago

I will note that I didn't try to just make existing React components compatible (which are in the web app), and instead chose to copy them. Creates a clean split, but its less code changed than it looks. That said a lot of the components did need changes due to react-router bundler or 'use client' directives.

dcramer commented 5 months ago

Going to merge this as it appears the only way to deploy on Vercel is out of main. Probably still some kinks to work out yet.