search

dcramer / peated

https://peated.com
Apache License 2.0
63 stars 13 forks source link

Early work on queue to moderate bottle matches #190

Closed dcramer closed 3 months ago

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 48.72881% with 121 lines in your changes missing coverage. Please review.

Project coverage is 73.23%. Comparing base (bc50a93) to head (bcef8c3). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
apps/server/src/trpc/routes/bottleAliasUpsert.ts 16.48% 76 Missing :warning:
apps/server/src/worker/jobs/onBottleAliasChange.ts 10.34% 26 Missing :warning:
apps/server/src/trpc/routes/entityAliasDelete.ts 72.41% 8 Missing :warning:
apps/server/src/trpc/routes/bottleAliasDelete.ts 88.09% 5 Missing :warning:
apps/server/src/trpc/routes/priceList.ts 33.33% 4 Missing :warning:
apps/server/src/trpc/routes/reviewList.ts 66.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #190 +/- ## ======================================== Coverage 73.22% 73.23% ======================================== Files 250 251 +1 Lines 18042 18152 +110 Branches 1429 1444 +15 ======================================== + Hits 13212 13293 +81 - Misses 4830 4859 +29 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 3 months ago

Honestly, its a jank flow.

Follow up is likely:

  1. Show likely match as a fast click on the table
  2. When match isnt available (aka score is too low via embedding?) or wrong, you bring up search dialog
  3. When search dialog finds nothing, you can create one. Create flow stays embedding and brings you back here.
  4. TBD: Matches have a debounce or something similar probably. Basically it'd be nice to have a way to hit undo, but maybe thats't oo much complexity.