search

dcramer / peated

https://peated.com
Apache License 2.0
64 stars 13 forks source link

Initial scaffolding for an Expo-based mobile app #192

Closed dcramer closed 4 months ago

dcramer commented 4 months ago

This kicks off our work on building a native mobile app. Its barebones at the moment, but has a lot of scaffolding up and running.

This also upgrades us to pnpm 9.5.0 catalogs in a variety of places, downgrades Next to 14 and React to 18 (RN and Expo are not yet compatible with React 19), and fixes a long-standing warning we had with misconfigured Tailwind.

Heavily inspired by create-t3-turbo's scaffolding: https://github.com/t3-oss/create-t3-turbo

dcramer commented 4 months ago

Probably going to remove NativeWind as it doesnt seem rational. I'll just build a better theme abstraction in the core design package.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 66.15385% with 44 lines in your changes missing coverage. Please review.

Project coverage is 73.03%. Comparing base (dbf1442) to head (07a9dba).

:white_check_mark: All tests successful. No failed tests found.

Files Patch % Lines
...server/src/worker/jobs/indexBottleSearchVectors.ts 0.00% 7 Missing :warning:
apps/server/src/trpc/client.ts 75.00% 6 Missing :warning:
apps/server/src/trpc/index.ts 50.00% 6 Missing :warning:
apps/server/src/trpc/query.ts 0.00% 6 Missing :warning:
apps/server/src/trpc/links.ts 82.75% 5 Missing :warning:
apps/server/src/lib/openai.ts 0.00% 4 Missing :warning:
apps/server/src/trpc/routes/userUpdate.ts 33.33% 4 Missing :warning:
...ps/server/src/worker/jobs/geocodeEntityLocation.ts 0.00% 3 Missing :warning:
apps/server/src/lib/log.ts 0.00% 2 Missing :warning:
apps/server/src/worker/jobs/scrapeSMWSA.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #192 +/- ## ========================================== - Coverage 73.13% 73.03% -0.10% ========================================== Files 251 253 +2 Lines 18249 18352 +103 Branches 1457 1462 +5 ========================================== + Hits 13347 13404 +57 - Misses 4902 4948 +46 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 4 months ago

I'm goint to merge this as otherwise itll end up a long lived branch and certainly cause some issues. Its not obvious to me that this wont break today's main due to hoisting changes, so that also helps us determine that pretty quickly.

dcramer commented 4 months ago

Backed out the Turbo change as I was having challenges getting it to play nicely with Docker. In general our Docker image is exclusively for the server app now, so we might consider changing things down the road.

dcramer commented 4 months ago

Alright I think its finally stable. A ton more I will refactor, but this PR is far too large and I'm not going to build it all inside a branch.