search

dcramer / peated

https://peated.com
Apache License 2.0
64 stars 13 forks source link

Augment names to prioritize releaseYear #200

Closed dcramer closed 4 months ago

dcramer commented 4 months ago

This shifts the UI to show (X Release) or (X Vintage) [in that prioritization order], and bundles up both aspects on bottle aliases for generated names.

It also adds the release year to uniqHash if vintageYear isnt available. We likely need to change unique hashes to support multiple, in the same guise as bottle aliases, but need to put some more thought into this.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.26%. Comparing base (8d633fb) to head (a66fb73). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #200 +/- ## ========================================== - Coverage 73.26% 73.26% -0.01% ========================================== Files 267 267 Lines 19524 19628 +104 Branches 1563 1568 +5 ========================================== + Hits 14304 14380 +76 - Misses 5220 5248 +28 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 4 months ago

I've probably made the test suite more flakey with this. Going to keep it for now, and just fix up tests as I go. I'd prefer the generic fixture data we more accurate, and get it to the point where we fully utilize it for mocks + tests.