search

dcramer / peated

https://peated.com
Apache License 2.0
64 stars 13 forks source link

Refactor duplicate code into scrapePrices #224

Closed dcramer closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 57.95455% with 37 lines in your changes missing coverage. Please review.

Project coverage is 75.62%. Comparing base (2199a9f) to head (850760e). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/server/src/worker/jobs/scrapeAstorWines.ts 16.66% 10 Missing :warning:
apps/server/src/worker/jobs/scrapeTotalWine.ts 16.66% 10 Missing :warning:
...pps/server/src/worker/jobs/scrapeHealthySpirits.ts 33.33% 6 Missing :warning:
apps/server/src/worker/jobs/scrapeReserveBar.ts 25.00% 6 Missing :warning:
apps/server/src/worker/jobs/scrapeWoodenCork.ts 28.57% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #224 +/- ## ========================================== + Coverage 74.60% 75.62% +1.02% ========================================== Files 300 300 Lines 17990 17882 -108 Branches 1916 1937 +21 ========================================== + Hits 13421 13524 +103 + Misses 4569 4358 -211 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dcramer commented 1 month ago

Something is broken with mocks still. I'm going to ignore it for now. Kind of hoping I can swap to bun and itll all just work. Lots of weird issues w/ the module loader/caching in vitest.