dcs-liberation / dcs_liberation

DCS World dynamic campaign.
GNU Lesser General Public License v3.0
711 stars 185 forks source link

[Build 1391/1394] Clicking on the Transfer Button Doesn't work When No Units are Transferring #1006

Closed Mustang-25 closed 3 years ago

Mustang-25 commented 3 years ago

Clicking the Transfer button in the misc section of the info bar does not open a window and generates the error shown in the pic below:

image

This occurs at Turn 0 and Turn 1 after units have already been purchased. From Turn 2 and onwards, the menu does seem to work and you can see that units are transferring. We infer from this that the menu will not open when there are no transfers actively occurring.

Expected behavior would be to produce a menu even if there are no transfers pending and it's blank.

Hornet2041 commented 3 years ago

works in #1394 tho

Mustang-25 commented 3 years ago

works in #1394 tho

negative, it does not for me.

Hornet2041 commented 3 years ago

seems to be a campaign issue. works fine in Peace Spring by Starfire <_<

Mustang-25 commented 3 years ago

After more testing, @Hornet2041 can also reproduce this in build 1394 with the Inherent Resolve campaign but his Peace Spring campaign does show that menu in turn 3 when units are being transferred. My own attempt at starting the Peace Spring campaign produces the same error so it seems to occur only when there are no units being transferred during that particular turn.

Hornet2041 commented 3 years ago

hmmmmmmmmmmmmm D:

Hornet2041 commented 3 years ago

looks like it will generate that error when the AI/player does not have any departing convoys

DanAlbert commented 3 years ago

Fixed. Accidentally removed a check when I was cleaning something up. It's back now.