join points may rendezvous outside wrong threat zone

[SnappyComebacks]

Describe the bug

• Split/Join points can generate hundreds of miles from the target. Nav points are jammed together between hold and join/split.
• Flight path can take you right through the worst of the threat zones

To Reproduce Steps to reproduce the behavior:

1. Create Operation Peace Spring campaign. Default faction/date.
2. Automate Ground Purchases
3. Purchase your favorite multirole aircraft.
4. Generate Strike mission on TARPON for split/join being far away behavior
5. Generate Strike mission on BUFFALO for split/join being far away and having a nav point crammed between hold and join.
6. Generate Strike mission on STOUT for interesting threat zone behavior

Expected behavior

• The split/join zone should probably be closer to the target.
• A nav point probably shouldn't be smushed between hold and join
• The ingress path shouldn't put you directly over the the biggest sam in the area?

Additional information 5.0_Preview_SplitPoint_Generated.zip

Version information (please complete the following information): Liberation 5.0.0-Preview

Additional context

STOUT and TARPON (TARPON highlighted.)

BUFFALO

[SnappyComebacks]

Additional debug tools can be enabled in WaypointDebugZonesControls.tsx

And when discussing NavMesh https://discord.com/channels/595702951800995872/595706037449785364/966186750332514355

ColonelPanic
Remember that the nav mesh is only used for nav routes
The rest of the waypoints are placed using the various zones
If that's what you're trying to fix
Navmesh does things like find a safe path from hold to join
Placing hold and join is handled by the hold zones/join zones

NavMesh colors on UI: Red = threatened, Green = not threatened.

[DanAlbert]

Not a regression, so punting.

[DanAlbert]

A nav point probably shouldn't be smushed between hold and join

Most likely a symptom of https://github.com/dcs-liberation/dcs_liberation/issues/701

The ingress path shouldn't put you directly over the the biggest sam in the area?

While not truly navmesh related, this does require the threat weighting (currently is binary) mentioned on https://github.com/dcs-liberation/dcs_liberation/issues/647.

The split/join zone should probably be closer to the target.

Yeah, this is the unique report in this bug. "Join points can be placed stupidly is there's a disconnected threat zone near the origin disassociated with the target's threat zone".

[DanAlbert]

This most likely will be solved without any more effort than migrating the old join zone placement to use the work in https://github.com/dcs-liberation/dcs_liberation/issues/3085.