Fix thanks regex

[abhisekp]

Current RegEx: https://regex101.com/r/hH5cN7/7 Proposed RegEx: https://regex101.com/r/hH5cN7 Repo file: https://github.com/dcsan/gitterbot/blob/master/nap/data/rooms/RoomMessages.js#L47

Replies to unwanted words such as tank and tanks must not be listened to

Don't listen to username with the regex pattern matching thanks.

Also thank on writing the following

• ty
• thanky
• thanksy
• thanxy
• thnq
• tq

[dting]

I think this might have been intentional for typos.

[abhisekp]

I think people never make typos such as tank instead of thnks or thnx, etc. So regex must be modified accordingly.

[dting]

I don't feel like people talk about tanks too often I would just leave this in and add the others if you think they are needed. At the same time I don't have any strong feelings about this issue.

[abhisekp]

@dting hence this issue is a Priority 3 and small issue. :smile: This is not a big thing to worry about.

[ArielLeslie]

Addressing alternative words (do you want to recognize 'gracias', etc), as well as a more stable/extendable option, I would suggest creating a dictionary of regex patterns rather than making one monster pattern.

[abhisekp]

@ArielLeslie, @dcsan have to decide whether to include thanks in other languages. But for now, english is way to go. The bot is in beta currently.

[ArielLeslie]

May also want to catch thankyou with a missing space.

[abhisekp]

Another regex thanks bug. @dj8923 types in Hindi. The regex matches the word tak.

[abhisekp]

Thanks command doesn't run for this

[ArielLeslie]

Adding a ! to the first alternative of the last group will fix that, but maybe it should just be any non-word instead of an ever-growing list of punctuation?

[abhisekp]

Thanks users with the following. Discovered by @brainyfarm

---